Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: Add GSoC'24 post on testing mimalloc memory allocator #443

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

huyang531
Copy link
Contributor

Signed-off-by: Yang Hu [email protected]

@huyang531 huyang531 marked this pull request as ready for review July 11, 2024 18:06
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comment.
Besides that, please sign-off your commit.

@StefanJum
Copy link
Member

@RaduNichita @razvanvirtan can you also take a look from a technical point of view?

@StefanJum
Copy link
Member

@huyang531 squash the commits, don't add the co-authored-by tag.

Copy link
Contributor

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments @huyang531

It is fairly intuitive to port the C program itself to Unikraft as the Musl library already provides most of what we need, including the `pthread` interface.
It would be ideal if we could separate the helper functions from the main logic and build the benchmark as a library (as we do need to test the memory allocator against more benchmarks in the future), because then we could just build an all-in-one image and run a large number of tests with different benchmarks and different parameters using an automated script.
However, I haven't figured out a good way to do it as [Unikraft's build system](https://unikraft.org/docs/internals/build-system#makefileuk) is quite complex.
So for now, the benchmark is ported as a single `main.c` file that will run as an application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have some preliminary results to put into the blogpost?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have the code ready - where should I put them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anywhere. You can create a repo on your github, or a gist or anything, lust add a link here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@StefanJum
Copy link
Member

@huyang531 use git config --global user.name "Your Name" and then amend the commit.
Right now it shows

Author: huyang531 <[email protected]>
Commit: huyang531 <[email protected]>

It should be your name and email.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Stefan Jumarea [email protected]
Approved-by: Stefan Jumarea [email protected]

@StefanJum StefanJum merged commit 3c94d08 into unikraft:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants