-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: Add GSoC'24 post on testing mimalloc memory allocator #443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the inline comment.
Besides that, please sign-off your commit.
content/blog/2024-07-12-unikraft-gsoc-test-mimalloc-on-unikraft.mdx
Outdated
Show resolved
Hide resolved
@RaduNichita @razvanvirtan can you also take a look from a technical point of view? |
@huyang531 squash the commits, don't add the co-authored-by tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments @huyang531
content/blog/2024-07-12-unikraft-gsoc-test-mimalloc-on-unikraft.mdx
Outdated
Show resolved
Hide resolved
content/blog/2024-07-12-unikraft-gsoc-test-mimalloc-on-unikraft.mdx
Outdated
Show resolved
Hide resolved
content/blog/2024-07-12-unikraft-gsoc-test-mimalloc-on-unikraft.mdx
Outdated
Show resolved
Hide resolved
content/blog/2024-07-12-unikraft-gsoc-test-mimalloc-on-unikraft.mdx
Outdated
Show resolved
Hide resolved
content/blog/2024-07-12-unikraft-gsoc-test-mimalloc-on-unikraft.mdx
Outdated
Show resolved
Hide resolved
content/blog/2024-07-12-unikraft-gsoc-test-mimalloc-on-unikraft.mdx
Outdated
Show resolved
Hide resolved
It is fairly intuitive to port the C program itself to Unikraft as the Musl library already provides most of what we need, including the `pthread` interface. | ||
It would be ideal if we could separate the helper functions from the main logic and build the benchmark as a library (as we do need to test the memory allocator against more benchmarks in the future), because then we could just build an all-in-one image and run a large number of tests with different benchmarks and different parameters using an automated script. | ||
However, I haven't figured out a good way to do it as [Unikraft's build system](https://unikraft.org/docs/internals/build-system#makefileuk) is quite complex. | ||
So for now, the benchmark is ported as a single `main.c` file that will run as an application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have some preliminary results to put into the blogpost?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do have the code ready - where should I put them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anywhere. You can create a repo on your github, or a gist or anything, lust add a link here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
content/blog/2024-07-12-unikraft-gsoc-test-mimalloc-on-unikraft.mdx
Outdated
Show resolved
Hide resolved
@huyang531 use
It should be your name and email. |
Signed-off-by: Yang Hu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Stefan Jumarea [email protected]
Approved-by: Stefan Jumarea [email protected]
Signed-off-by: Yang Hu [email protected]